Conversation
- Scope site_detail.css grid layout to only .site-detail context - Add rule for gallery-image-link inside gallery-item to fill container - Info page galleries with 4 images now display in single row (25% each) - Modal/site detail pages still use 2x2 grid for 4 images 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Display curated images showcasing different architectural styles: - Italianate (815 Milwaukee St) - Tudor Revival (1020 Milwaukee St) - Queen Anne (1017 Milwaukee St, 903 Dodge St) - Second Empire (1102 Dodge St) - Colonial Revival (805 Dodge St) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The selected site's marker and sidebar item now stay highlighted after closing the modal, making it easy to see which site was just viewed. Highlighting clears when selecting a different site or using browser back. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a header gallery of historic architecture to the map page, showcasing six representative buildings from different architectural styles. The PR also includes marker state management improvements to keep selected sites highlighted, and updates to board member information.
Key Changes:
- Added a header gallery on the map page featuring six historic homes representing different architectural styles (Italianate, Tudor Revival, Queen Anne, Second Empire, Colonial Revival)
- Enhanced map marker interactions to maintain highlighting for the last selected site after modal close
- Updated board member information to reflect Christian St. John's active status and removed contact details for some board members
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| db/schema.rb | Updated ActiveRecord schema version from 8.0 to 8.1 with alphabetically reordered columns |
| app/views/shared/_members.html.erb | Removed "vacant" class from Christian St. John, removed contact info for several board members, commented out vacant styling |
| app/views/shared/_map_script.html.erb | Added state management to keep map markers highlighted for selected sites after modal closure |
| app/views/main/index.html.erb | Added conditional rendering of header gallery with historic architecture images |
| app/controllers/main_controller.rb | Added HEADER_SITE_ADDRESSES constant with six specific sites and logic to retrieve their images |
| app/assets/stylesheets/pages/site_detail.css | Made gallery selector more specific to site detail pages |
| app/assets/stylesheets/components/gallery.css | Added CSS rules for map header gallery (6 images in a row) and info page galleries (4 images in a row) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tests now verify that sidebar highlighting persists after closing the modal, matching the new intentional behavior where the last selected site stays highlighted until a different site is selected. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.