Skip to content

fix: remove redundant calculation of storage key. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

fix: remove redundant calculation of storage key. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,8 @@ where
let method = request.method();
let uri = request.uri();

let key = storage_key(method, uri);
if matches!(*method, Method::GET | Method::HEAD) {
let key = storage_key(method, uri);
match self.storage.get(&key).await {
Ok(Some((response, policy))) => {
debug!(
Expand Down Expand Up @@ -351,14 +351,16 @@ where
}
}

self.send_upstream(request, CacheLookupStatus::Miss).await
self.send_upstream(key, request, CacheLookupStatus::Miss)
.await
}

/// Sends the original request upstream.
///
/// Caches the response if the response is cacheable.
async fn send_upstream<B: HttpBody>(
&self,
key: String,
request: impl Request<B>,
lookup_status: CacheLookupStatus,
) -> Result<Response<Body<B>>> {
Expand All @@ -370,7 +372,6 @@ where

response.set_cache_status(lookup_status, CacheStatus::Miss);

let key = storage_key(&request_like.method, &request_like.uri);
if matches!(request_like.method, Method::GET | Method::HEAD)
&& response.status() == StatusCode::OK
&& policy.is_storable()
Expand Down