sample tests for XML.toJSONObject(Reader) #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit just has a single sample test where the JSONObject is built and tested with StringReader
and FileReader instead of just String. Ideally, all tests in this module that compare an expected string
to the result of XML.toJSONObject(String) should be modified so that all 3 tests are performed.
Unit tests verify new behavior, but mostly they are used to protect against regressions due to
unintended consequences of other code changes. In this case, a third reason is emphasized.
We think that toJSONObject(String) and toJSONObject(Reader) produce exactly the same result.
But we don't really know this for a fact. So the unit tests will confirm whether this is the case.
This branch should not be merged until the corresponding code changes proposed in
stleary/JSON-java#146 have been pushed. The modified test
will not even compile until then.