Skip to content

Tests for Issue #240 in JSON-Java #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stleary merged 5 commits into from
Jun 17, 2016
Merged

Tests for Issue #240 in JSON-Java #50

stleary merged 5 commits into from
Jun 17, 2016

Conversation

@johnjaylward
Copy link
Contributor

@johnjaylward johnjaylward commented Jun 16, 2016

So this includes 2 changes:

  1. Updates the build.gradle and the source folder locations to match the default gradle configuration. This makes it easier to get imported into IDE tools like Eclipse or Netbeans.
  2. Adds a test case that cycles through all the control characters as defined in RFC 7159 and verifies the validity of each character. The ones that don't pass are \0, \n, and \r. The test case verifies these failures as well

johnjaylward and others added 3 commits June 16, 2016 11:44
@johnjaylward
Merge pull request #1 from stleary/master
0e0f3f2 
update from origin
Moves src folder to simplify build.gradle configuration. If JSON-Java…
80f9e48 
… source is merged, it's src fold would now be src/main/java/org.json/ instead of src/main/org.json as well.
Adds test case to confirm the parsing of control characters
46a1c9a
@johnjaylward johnjaylward mentioned this pull request Jun 16, 2016
Closed
@stleary
Copy link
Owner

stleary commented Jun 17, 2016

Clearly documents the actual behavior. Look good, thanks. Would you please also update the README in the pull request, which I think is no longer accurate?

@johnjaylward
Copy link
Contributor Author

johnjaylward commented Jun 17, 2016

that should fix the paths. Also added the Unix type commands

@stleary stleary merged commit 01af317 into stleary:master Jun 17, 2016
@stleary stleary mentioned this pull request Jun 17, 2016
Merged
@johnjaylward johnjaylward deleted the issue240 branch July 10, 2017 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnjaylward @stleary