Rename some function parameters to solve -Wshadow issue in SPI and EEPROM libraries #2880
+15
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think -Wshadow is a good feature to avoid silly mistakes, like:
I have wasted some time on my silliness recently. So I think it's good to have this warning turned on, and when I do it, SPI and EEPROM libraries make the compiler complain.
This PR just renames those parametes, nearly no cost.