Skip to content

ST25DV sensor driver implementation#1

Merged
cparata merged 6 commits intostm32duino:masterfrom
ABOSTM:ST25DV
Mar 6, 2020
Merged

ST25DV sensor driver implementation#1
cparata merged 6 commits intostm32duino:masterfrom
ABOSTM:ST25DV

Conversation

@ABOSTM
Copy link
Copy Markdown
Contributor

@ABOSTM ABOSTM commented Mar 2, 2020

Summary
ST25DV sensor driver implementation

Driver ST25DV extracted from X-NUCLEO-NFC04A1

@ABOSTM ABOSTM requested review from cparata and fpistm March 2, 2020 14:59
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread src/BSP/x_nucleo_nfc04a1_nfctag.h Outdated
Comment thread src/ST25DVSensor.h Outdated
Comment thread src/libNDEF/NDEFcommon.h Outdated
Comment thread src/libNDEF/NDEFcommon.h
Comment thread src/libNDEF/NDEFcommon.h
@cparata
Copy link
Copy Markdown
Contributor

cparata commented Mar 2, 2020

Hi @ABOSTM ,
I tested the new 2 libraries and they are functional also with X-NUCLEO-NFC04A1. I'm just wondering if this is a good occasion to remove some warnings that are inside the libraries. Some of them should be quite simple to remove. What about that?
Best Regards,
Carlo

Copy link
Copy Markdown
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ABOSTM added 2 commits March 6, 2020 15:18
Previously error was not correctly reported:
 (String)NULL was interpreted by compiler as "0"
This fix compilation warning.
Note: this modify the API.
@cparata cparata merged commit 809da46 into stm32duino:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants