Conversation
|
✅ Linter reported no issues All Python files are correctly formatted with Black. |
|
✅ Linter reported no issues All C/C++ files are correctly formatted with clang-format. |
|
Seems like that did it- for some reason, my thrust libraries are worse than yours so the implicit cpu->gpu copy failed when the CUDA execution policy is specified. Do you think we should add an issue to convert the rest of lanczos to be purely GPU, if that's a feasible task? If so, I'd give it a go sometime in the future. |
rykerfish
left a comment
There was a problem hiding this comment.
Looks good! My small change fixed the crash I was having so it seems good to go.
|
AFAICT, all the operations I left in the CPU have to be in the CPU. Some decisions must be performed CPU-side (like convergence checking). |
This PR adds a new optional parameter to initialize, a callable that takes an integer and a float.
If passed and lanczos is used to compute the noise the callback will be invoked with the current iteration number and the current error after each iteration.