switch to install-time stub generation #72
Merged
+20
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linter reported no issues All Python files are correctly formatted with Black. |
|
✅ Linter reported no issues All C/C++ files are correctly formatted with clang-format. |
RaulPPelaez
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conda-forge build was having an issue where it needed to import each solver and thus required access to runtime BLAS libraries which aren't included in the build-time environment. Nanobind stub generation has an option to only generate stubs at install time, which I think uses the
hostdependencies on conda-forge and do include BLAS.I used this branch to create a patch for the v1.1.1 PR. I figured we should keep the same build here and on conda-forge so I'm PRing it here as well, although we shouldn't create a new release for this since I included it in the patch. I think we'll need to remove the patch file in the feedstock upon the next version release.
@RaulPPelaez if this looks okay to you, could you merge the feedstock PR as well?