fix useFleetK8sAPIPath throwing errors#4746
fix useFleetK8sAPIPath throwing errors#4746upalatucci wants to merge 1 commit intostolostron:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: upalatucci The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @upalatucci. Thanks for your PR. I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Ugo Palatucci <upalatuc@redhat.com>
90d81ee to
4375c01
Compare
|
@upalatucci We are in the process of rewriting the hub name detection anyway, because accessing the @nitin-dhevar Can you make sure that for @jeswanke Can you make sure that @vishsanghishetty Can you review the changes for event stream and get them merged? |
|
@KevinFCormier @jeswanke we should also make sure to return the default k8s api when no cluster is provided :D as i forgot |
We have to guard if the cluster that we are running does not have
ManagedClusterCRD installed (as it does not have acm maybe)If no cluster provided there is no need to fire requests and waiting. We already know that its the local cluster.
Other fixes are typescripts complains during build