ACM-28831 Disable AppSet auto sync when the option is unchecked#5513
ACM-28831 Disable AppSet auto sync when the option is unchecked#5513openshift-merge-bot[bot] merged 3 commits intostolostron:mainfrom
Conversation
Signed-off-by: fxiang1 <fxiang@redhat.com>
|
/retest |
|
/hold |
KevinFCormier
left a comment
There was a problem hiding this comment.
Hey Feng. The behaviour seems a little strange to me.
- "Automatically sync when cluster state changes" corresponds to selfHeal, but when it is not checked, would it be equivalent if we set the other 2 options under automated (prune and allowEmpty) to false as well, rather than nulling it out?
- Should we re-order the checkboxes to show the relationship between this one and the other two that become disabled?
- When I loaded an application where the "automated" section had been removed for editing, the 2 checkboxes were not disabled.
There was also a stray macOS file checked in that should be removed.
There was a problem hiding this comment.
Please remove this file. I see it is gitignored for frontend, but you could add the ignore at the root level instead.
Signed-off-by: fxiang1 <fxiang@redhat.com>
Signed-off-by: fxiang1 <fxiang@redhat.com>
Thanks Kevin! The changes for these comments are done. |
|
/lgtm |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fxiang1, KevinFCormier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|



📝 Summary
Ticket Summary (Title):
Implement option to disable AppSet autosync completely
Enable automated synccheckbox which will disable all other settings when uncheckedEnable automated syncwill enabled the other settings againsyncPolicy.automatedexists but noenabledfield. This will addenabled=trueby default.Ticket Link:
https://issues.redhat.com/browse/ACM-28831
Type of Change:
✅ Checklist
General
ACM-12340 Fix bug with...)If Feature
If Bugfix
🗒️ Notes for Reviewers