Skip to content

Turn on checks for PRs against release-2.16#5657

Merged
openshift-merge-bot[bot] merged 1 commit intostolostron:release-2.16from
Randy424:ACM-29136-ACM-29137-tekton-release-2.16
Feb 11, 2026
Merged

Turn on checks for PRs against release-2.16#5657
openshift-merge-bot[bot] merged 1 commit intostolostron:release-2.16from
Randy424:ACM-29136-ACM-29137-tekton-release-2.16

Conversation

@Randy424
Copy link
Contributor

@Randy424 Randy424 commented Feb 9, 2026

📝 Summary

Ticket Summary (Title):

Ticket Link:

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

  • UI/UX reviewed (if applicable)
  • All acceptance criteria met
  • Unit test coverage added or updated
  • Relevant documentation or comments included

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

@Randy424 Randy424 changed the base branch from main to release-2.16 February 9, 2026 16:15
@Randy424
Copy link
Contributor Author

Randy424 commented Feb 9, 2026

/retest

@Randy424
Copy link
Contributor Author

Randy424 commented Feb 9, 2026

/retest-required

pipelinesascode.tekton.dev/cancel-in-progress: "true"
pipelinesascode.tekton.dev/max-keep-runs: "3"
pipelinesascode.tekton.dev/on-cel-expression: event == "pull_request" && target_branch == "main"
pipelinesascode.tekton.dev/on-cel-expression: event == "pull_request" && target_branch == "backplane-2.11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember we don't open PRs against backplane branches.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna have to tattoo that on my forearm 😅
Thanks.

Signed-off-by: Randy Bruno Piverger <21374229+Randy424@users.noreply.github.com>
@Randy424 Randy424 force-pushed the ACM-29136-ACM-29137-tekton-release-2.16 branch from 2da3a1e to a55209f Compare February 9, 2026 18:33
@Randy424
Copy link
Contributor Author

Randy424 commented Feb 9, 2026

/retest

@Randy424
Copy link
Contributor Author

/hold

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, Randy424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [KevinFCormier,Randy424]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Randy424
Copy link
Contributor Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit c017143 into stolostron:release-2.16 Feb 11, 2026
11 checks passed
@jeswanke jeswanke mentioned this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants