Skip to content

[AI CVE test] fix(deps): update Node.js dependencies and resolve CVEs#6080

Closed
fxiang1 wants to merge 1 commit intostolostron:mainfrom
fxiang1:fix/deps-security-audit
Closed

[AI CVE test] fix(deps): update Node.js dependencies and resolve CVEs#6080
fxiang1 wants to merge 1 commit intostolostron:mainfrom
fxiang1:fix/deps-security-audit

Conversation

@fxiang1
Copy link
Copy Markdown
Contributor

@fxiang1 fxiang1 commented May 1, 2026

  • Upgraded lint-staged to v16 (root) to resolve micromatch ReDoS and yaml stack overflow
  • Upgraded @octokit/rest 19.0.13 → 20.1.2 to resolve ReDoS in request/paginate-rest/request-error
  • Upgraded @sentry/browser 6.19.7 → 7.120.4 to resolve prototype pollution (GHSA-593m-55hh-j8gv)
  • Upgraded storybook 8.0.9 → 8.6.18 to resolve esbuild, ip SSRF, and transitive CVEs
  • Upgraded i18next-http-backend 1.4.5 → 3.0.6 to resolve path traversal (GHSA-q89c-q3h5-w34g)
  • Upgraded compression-webpack-plugin, copy-webpack-plugin, css-minimizer-webpack-plugin to resolve serialize-javascript RCE (GHSA-5c6j-r48x-rmvq)
  • Added tar override (7.5.13) to fix 6 path traversal CVEs in storybook CLI chain
  • Removed deprecated webpack-dev-server https option (replaced by server.type in v5)
  • Applied non-breaking npm audit fix across root, frontend, and backend
  • Root: 0 vulnerabilities (was 5)
  • Backend: 0 vulnerabilities (was 7)
  • Frontend: 25 remaining (was 71), all in devDependency transitive chains (uuid, merge, js-yaml, vue-template-compiler, @tootallnate/once)
  • Backend build, lint, and tests pass
  • Frontend lint and tests pass (5341/5342, 1 pre-existing flaky test)

📝 Summary

Ticket Summary (Title):
Testing changes made to https://github.com/stolostron/cve-prompts to support React / Node.js packages.

Ticket Link:

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

  • UI/UX reviewed (if applicable)
  • All acceptance criteria met
  • Unit test coverage added or updated
  • Relevant documentation or comments included

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

Summary by CodeRabbit

  • Chores
    • Updated project dependencies to latest stable versions, including build tooling and development utilities
    • Adjusted development server configuration for HTTPS handling
    • Applied security constraint on tar dependency

- Upgraded lint-staged to v16 (root) to resolve micromatch ReDoS and yaml stack overflow
- Upgraded @octokit/rest 19.0.13 → 20.1.2 to resolve ReDoS in request/paginate-rest/request-error
- Upgraded @sentry/browser 6.19.7 → 7.120.4 to resolve prototype pollution (GHSA-593m-55hh-j8gv)
- Upgraded storybook 8.0.9 → 8.6.18 to resolve esbuild, ip SSRF, and transitive CVEs
- Upgraded i18next-http-backend 1.4.5 → 3.0.6 to resolve path traversal (GHSA-q89c-q3h5-w34g)
- Upgraded compression-webpack-plugin, copy-webpack-plugin, css-minimizer-webpack-plugin
  to resolve serialize-javascript RCE (GHSA-5c6j-r48x-rmvq)
- Added tar override (7.5.13) to fix 6 path traversal CVEs in storybook CLI chain
- Removed deprecated webpack-dev-server https option (replaced by server.type in v5)
- Applied non-breaking npm audit fix across root, frontend, and backend
- Root: 0 vulnerabilities (was 5)
- Backend: 0 vulnerabilities (was 7)
- Frontend: 25 remaining (was 71), all in devDependency transitive chains
  (uuid, merge, js-yaml, vue-template-compiler, @tootallnate/once)
- Backend build, lint, and tests pass
- Frontend lint and tests pass (5341/5342, 1 pre-existing flaky test)

Signed-off-by: fxiang <fxiang@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

📝 Walkthrough

Walkthrough

Multiple dependency version updates across the project: Storybook, webpack plugins, Octokit, Sentry, i18next-http-backend, and lint-staged packages are upgraded. An npm override pins tar to version 7.5.13. The webpack dev server configuration removes a deprecated flag while keeping HTTPS protocol configuration.

Changes

Cohort / File(s) Summary
Frontend Primary Dependencies
frontend/package.json
Updates @octokit/rest, @octokit/types to caret ranges; upgrades i18next-http-backend from 1.4.5 to ^3.0.6; bumps @sentry/browser to ^7.120.4. Adds npm overrides block forcing tar to 7.5.13 for security/stability.
Frontend Storybook Ecosystem
frontend/package.json
Upgrades Storybook core and addon packages (addons, cli, core-common, react, react-webpack5, storybook) from pinned 8.0.9 to ^8.6.18.
Frontend Webpack Tooling
frontend/package.json, frontend/packages/react-form-wizard/package.json
Upgrades webpack plugins: compression-webpack-plugin to ^12.0.0, copy-webpack-plugin to ^14.0.0, css-minimizer-webpack-plugin to ^8.0.0 across both packages.
Webpack Configuration
frontend/webpack.config.ts
Removes deprecated https: true flag from devServer configuration; HTTPS protocol remains configured via devServer.server.type.
Root Tooling
package.json
Upgrades lint-staged from ^13.3.0 to ^16.4.0 in devDependencies.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description provides detailed change summaries and vulnerability fixes but fails to complete the required template structure and checklist. Complete all checklist items (mark boxes as checked/unchecked), select a Type of Change, and provide a Ticket Link. The informative preamble is valuable but the template sections require explicit attention.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the primary objective: dependency updates to resolve CVEs. It is specific, clear, and directly reflects the changeset's main purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label May 1, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 1, 2026

@fxiang1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check da41253 link true /test check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fxiang1
Copy link
Copy Markdown
Contributor Author

fxiang1 commented May 4, 2026

Closing, as the AI didn't make sure check fix is working.

@fxiang1 fxiang1 closed this May 4, 2026
@fxiang1 fxiang1 deleted the fix/deps-security-audit branch May 4, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant