Skip to content

ACM-33632 Remove references to old PF5 CSS vars#6103

Open
KevinFCormier wants to merge 1 commit intostolostron:mainfrom
KevinFCormier:fix-pf-css-vars
Open

ACM-33632 Remove references to old PF5 CSS vars#6103
KevinFCormier wants to merge 1 commit intostolostron:mainfrom
KevinFCormier:fix-pf-css-vars

Conversation

@KevinFCormier
Copy link
Copy Markdown
Contributor

@KevinFCormier KevinFCormier commented May 5, 2026

📝 Summary

Ticket Summary (Title):
Additional labels field has bold outline on OCP 4.22

Ticket Link:
https://redhat.atlassian.net/browse/ACM-33632

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

After Fix

image

Summary by CodeRabbit

  • Style
    • Updated styling for cluster creation form labels to ensure consistency with the latest design system standards.

Signed-off-by: Kevin Cormier <kcormier@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6881f4eb-72dd-431c-b7cd-c420189051d0

📥 Commits

Reviewing files that changed from the base of the PR and between 0c671d0 and fd2415f.

📒 Files selected for processing (1)
  • frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateCluster/style.css

📝 Walkthrough

Walkthrough

A single CSS stylesheet was updated to migrate border styling variables from PatternFly v5 to v6, replacing version-specific variables with unified global border width and color CSS custom properties for two label container classes.

Changes

PatternFly v5 to v6 CSS Variable Migration

Layer / File(s) Summary
Styling Update
frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateCluster/style.css
Border declarations for .temptifly-controls-labels-container and .creation-view-controls-labels-container updated to use --pf-t--global--border--width--regular and --pf-t--global--border--color--default variables, replacing PatternFly v5 variables with directional variance. Selectors and box-shadow: unset !important; behavior unchanged.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title directly references the main change: removing old PatternFly v5 CSS variable references and updating to v6 variables in the stylesheet.
Description check ✅ Passed Description follows the template structure with ticket summary, link, type of change selected, and most checklist items completed. However, 'Root cause and fix summary documented in ticket' and 'Tests added to prevent regression' are unchecked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@KevinFCormier
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-2.17

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@KevinFCormier: once the present PR merges, I will cherry-pick it on top of release-2.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@KevinFCormier
Copy link
Copy Markdown
Contributor Author

/cc @zlayne

@openshift-ci openshift-ci Bot requested a review from zlayne May 5, 2026 20:24
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, zlayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [KevinFCormier,zlayne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants