feat(try-it): support file uploads - without base64 support #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 11, 2021 14:38
# Conflicts: # packages/elements/package.json # packages/elements/src/components/TryIt/index.tsx # packages/elements/src/components/TryIt/parameter-utils.ts
|
✔️ Deploy preview for stoplight-elements ready! 🔨 Explore the source changes: a5936d8 🔍 Inspect the deploy logs: https://app.netlify.com/sites/stoplight-elements/deploys/6005b5ab8b04d60008e76edb 😎 Browse the preview: https://deploy-preview-813--stoplight-elements.netlify.app |
mallachari
approved these changes
Jan 18, 2021
mallachari
left a comment
mallachari
left a comment
There was a problem hiding this comment.
Still looking good and still working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #648
Exactly @mpodlasin's PR #807, except its last commit (base64 support).
Mateusz is not feeling well today and the end of sprint is getting near so let's make sure File Support gets merged. File support is useful even without the base64 feature, so it makes sense to treat this as 1 PR, then add Base64 support in another. (I'm not even sure if Base64 was a product requirement or @mpodlasin's own initiative to make the feature even better.)
#807 was already approved at exactly this point (before base64) so this should not take much to get through.