fix: continueOnError behaves correctly when parsing result is empty #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
reviewed
Jun 16, 2020
lib/parse.js
Outdated
|
|
||
| function onParsed (parser) { | ||
| if ((options.continueOnError || !parser.plugin.allowEmpty) && isEmpty(parser.result)) { | ||
| if (!options.continueOnError && !parser.plugin.allowEmpty && isEmpty(parser.result)) { |
There was a problem hiding this comment.
This is close, but not quite correct.
We should still throw when continueOnError true, so the condition could look as follows
Suggested change
| if (!options.continueOnError && !parser.plugin.allowEmpty && isEmpty(parser.result)) { | |
| if (!parser.plugin.allowEmpty && isEmpty(parser.result)) { |
You may need to pass allowEmpty in exporter service
There was a problem hiding this comment.
allowEmpty defaults to true && I fixed this continueOnError.
P0lip
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes condition which controls rejection of empty parsing result.
continueOnError has to be falseandallowEmpty has to be falsein order for the empty result to cause rejectionThis fixes https://github.com/stoplightio/platform-internal/issues/2822