Custom bundling #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billiegoose
approved these changes
Nov 12, 2020
Comment on lines
259
to
275
| if (!entry.inlineable && customRoots[entry.file] && customRoots[entry.file][entry.hash]) { | ||
| if (entry.hash === "#") { | ||
| set(schema, customRoots[entry.file]["#"], $Ref.dereference(entry.$ref, entry.value)); | ||
| entry.$ref.$ref = customRoots[entry.file]["#"]; | ||
| } | ||
| else { | ||
| let subschema = get(schema, customRoots[entry.file]["#"]); | ||
| let parsedHash = safePointerToPath(entry.hash); | ||
| let value = get(subschema, `#/${parsedHash.length === 1 ? parsedHash[0] : parsedHash.slice(0, parsedHash.length - 1).join("/")}`); | ||
| set(schema, customRoots[entry.file][entry.hash], parsedHash.length === 1 ? value : value[parsedHash[parsedHash.length - 1]]); | ||
| delete value[parsedHash[parsedHash.length - 1]]; | ||
| } | ||
|
|
||
| pathFromRoot = entry.pathFromRoot; | ||
| hash = customRoots[entry.file][entry.hash]; | ||
| entry.$ref.$ref = entry.pathFromRoot; | ||
| } |
There was a problem hiding this comment.
Can you add a comment (or more) here? I can't figure out what it's doing. Is this where it's rewriting the pointers to point at the bundled schemas?
There was a problem hiding this comment.
Good point. I'll leave a comment explaining what's happening here.
There was a problem hiding this comment.
@wmhilton added! LMK what you think.
Co-authored-by: William Hilton <wmhilton@gmail.com>
Co-authored-by: William Hilton <wmhilton@gmail.com>
|
@marbemac ping, I want to have this in assuming the output meets the expectations. |
marbemac
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/stoplightio/platform-internal/issues/4468
TODO:
Can be tried in the repo I sent on Slack.