Skip to content

Conversation

@brendarearden
Copy link

Motivation and Context

stoplightio/prism#2385

Description

Urls were getting their their slashed converted on windows, so we need to only url.toFileSystemPath on non browser urls.

How Has This Been Tested?

Locally on mac
Locally on Windows - I do still get an error, but it is the same error that already exists https://github.com/stoplightio/json-schema-ref-parser/actions/runs/6015113363/job/16316297504

Screenshot(s)/recordings(s)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@brendarearden brendarearden force-pushed the fix/2385-external-ref-resolution branch from d57d080 to 50ac502 Compare October 5, 2023 21:15
@brendarearden brendarearden requested review from a team and EdVinyard and removed request for a team October 5, 2023 21:18
Copy link

@EdVinyard EdVinyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I left one question (that you may have already answered and I've forgotten) and one take-it-or-leave-it suggestion.

@brendarearden brendarearden force-pushed the fix/2385-external-ref-resolution branch from 50ac502 to b72c855 Compare October 5, 2023 22:12
@mmarti21 mmarti21 merged commit 79a8cda into master Oct 9, 2023
@mmarti21 mmarti21 deleted the fix/2385-external-ref-resolution branch October 9, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants