fix: readOnly/writeOnly not respected for >=2 levels #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
requested review from
domagojk and
paulatulis
and removed request for
a team
domagojk
approved these changes
Mar 30, 2021
Contributor
domagojk
left a comment
domagojk
left a comment
There was a problem hiding this comment.
Looks good and I can confirm it works!
Collaborator
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/stoplightio/platform-internal/issues/5476
This is already fixed in beta, which uses entirely different code, but Studio cannot use v4 just yet, thus a dedicated change had to be applied.
FWIW, I'm glad we moved all the complexity away from JSV 😅
v3 is quite tangled at this point.