Skip to content

Conversation

@P0lip
Copy link
Contributor

@P0lip P0lip commented Apr 7, 2021

Addresses https://github.com/stoplightio/platform-internal/issues/5799

image
I'm so happy this code is entirely gone in beta, and that JST has it done more reasonably 🙈

tickets.schema.json has been updated due to that fix, see the portion of that whole schema document

    "ticketRecipients": {
                            "type": "array",
                            "items": {
                              "type": "string",
                              "enum": [
                                "BOOKER",
                                "CUSTOMER",
                                "PASSENGER",
                                "THIRD_PARTY"
                              ]
                            }
                          },

@P0lip P0lip added the t/bug Something isn't working label Apr 7, 2021
@P0lip P0lip requested a review from a team April 7, 2021 23:18
@P0lip P0lip self-assigned this Apr 7, 2021
@P0lip P0lip requested a review from paulatulis April 7, 2021 23:18
Copy link
Contributor

@paulatulis paulatulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I pulled down the branch and tested with the example you show in the summary (thanks for including), and it does what it says it should. I just have one question about the variable name.

@P0lip P0lip requested a review from paulatulis April 8, 2021 21:46
Copy link
Contributor

@paulatulis paulatulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bueno

@P0lip P0lip merged commit 5304cb4 into master Apr 9, 2021
@P0lip P0lip deleted the fix/enum-array branch April 9, 2021 10:36
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released t/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants