feat: primary type #18
Conversation
src/utils/walk.ts
Outdated
| annotations: getAnnotations(node), | ||
| enum: node.enum, | ||
| }; | ||
| function getPrimaryType(node: JSONSchema4) { |
There was a problem hiding this comment.
what if type is ["object", "array"]
There was a problem hiding this comment.
Really the user should be using a oneOf like below, but if having both in type is valid json-schema we definitely need to support it
{
"oneOf": [
{"$ref": "#/definitions/singleObject"}, // plain object
{
"type": "array", // array of plain objects
"items": {"$ref": "#/definitions/singleObject"}
}
],
"definitions": {
"singleObject": {...}
}
}
There was a problem hiding this comment.
This also means that if type is ["object", "array"] we need to infer that its a combiner type oneOf so it renders properly in the ui
There was a problem hiding this comment.
Yeah, shared the same concern here #17 (comment).
I'm not sure if displaying oneOf is safe though. To me, it sounds like a nice idea, but we'll need to make it reliable (transform the data correctly).
@marbemac, what's your take on this?
There was a problem hiding this comment.
I think we don't worry about this use case until a customer complains about it.
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.