fix incorrect rendering of array of objects with no type [STU-362] #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-miaskowski
approved these changes
Jul 12, 2019
Collaborator
|
🎉 This PR is included in version 2.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
P0lip
reviewed
Jul 12, 2019
| '$ref' in parsedSchema.items | ||
| ? `$ref( ${parsedSchema.items.$ref} )` | ||
| : parsedSchema.items.type || | ||
| (parsedSchema.items.properties && 'object') || |
Contributor
There was a problem hiding this comment.
(parsedSchema.items.properties && 'object')
The RHS will always be truthy.
EDIT:
just realized you want to have object returned here, so it's okay.
Contributor
|
This PR will need to be revamped a bit, as we have Suggest adding Chris or Nick to the PRs, they have a fairly decent experience with JSV, so they might spot such nuances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to STU-362
Changes:
Context:
Issue appeared only for arrays that contained objects without specified type. This way node subtype property was undefined and the process of node children rendering stopped.
Before:
After:
