Skip to content

fix incorrect rendering of array of objects with no type [STU-362] #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2019
Merged

fix incorrect rendering of array of objects with no type [STU-362] #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/utils/renderSchema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,12 @@ export const renderSchema: Walker = function*(schema, level = 0, meta = { path:
...meta,
...(parsedSchema.items !== undefined &&
!Array.isArray(parsedSchema.items) && {
subtype: '$ref' in parsedSchema.items ? `$ref( ${parsedSchema.items.$ref} )` : parsedSchema.items.type,
subtype:
'$ref' in parsedSchema.items
? `$ref( ${parsedSchema.items.$ref} )`
: parsedSchema.items.type ||
(parsedSchema.items.properties && 'object') ||
Copy link
Contributor

@P0lip P0lip Jul 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(parsedSchema.items.properties && 'object')
The RHS will always be truthy.

EDIT:
just realized you want to have object returned here, so it's okay.

(parsedSchema.items.items && 'array'),
}),
path,
},
Expand Down