feat: introduce rowRendererRight #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2019 11:38
…to refactor/stu-313-masks
mallachari
suggested changes
Jul 11, 2019
mallachari
left a comment
mallachari
left a comment
There was a problem hiding this comment.
Looks good in general. I'll run it locally but for now just few comments.
P0lip
reviewed
Jul 11, 2019
Contributor
|
I reviewed the code and it's alright. If the component looks okay, we can merge it. I'm not fully happy with that renderer prop, yet I won't reject PR because of this. |
Author
Cool! Thank you, can you please hit approve in such case? Would get one dependency ticked off. |
P0lip
approved these changes
Jul 11, 2019
Collaborator
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change is introduced
rowRendererRightagnostic of the content (will enable Studio to render checkboxes). This component renders arbitrary elements on the right hand side of the row.schemaControlsRendereragnostic of the content (will enable Studio to render 'apply mask' and 'clear mask' buttons). This renders any content right under the JSON SchemarowRendererRighthad any margin or modified height in any way. it resulted in that parent's calculated height to be altered and therefore the relative positionig of divider become broken. We had to usecalcbut it's supported by all major browsers.See a storybook with example checkbox added.