fix: do not mutate combiner child #59
Conversation
| for (const [i, property] of node.properties.entries()) { | ||
| if ('type' in node) { | ||
| property.type = property.type || node.type; | ||
| node.properties[i] = { |
There was a problem hiding this comment.
So is this needed in general? Feels like it might not be.
There was a problem hiding this comment.
Yeah, it's needed. If you revert it, a few tests covering mutation will fail.
There was a problem hiding this comment.
Are you sure? For me only two tests fail, both snapshots regarding the "type": "object" thing. Not saying that means everything is good, but just that the tests don't seem to indicate any big issues?
There was a problem hiding this comment.
For me only two tests fail,
Yup, these are the only ones, since they cover the combiner children case.
Not saying that means everything is good, but just that the tests don't seem to indicate any big issues?
That's right, seems like this was the only spot.
|
🎉 This PR is included in version 2.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #58
A note on snapshot change - it shouldn't have any impact, since the actual node that gets rendered in tree-list has a proper type assigned - see line 146 and line 197.
It's just that the other nodes point at original object.
You can also verify it manually in storybook by pasting the schema file and comparing the view. :P
This got me realize we actually seem to squeeze too much into metadata. It seems like we could make it much leaner.