Skip to content

fix(rulesets): exclude non-schema enum properties from duplicated-entry-in-enum rule #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomek-tursa-sb merged 4 commits into from
May 20, 2026
Merged

fix(rulesets): exclude non-schema enum properties from duplicated-entry-in-enum rule #2934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6472ad8
fix(rulesets): exclude non-schema enum properties from duplicated-ent…
slegarraga Apr 6, 2026
6a206ea
Merge branch 'develop' into fix/issue-2199
tomek-tursa-sb Apr 21, 2026
9b51f58
chore: restore generated Arazzo validators bundle
slegarraga May 20, 2026
69e540b
Merge branch 'develop' into fix/issue-2199
tomek-tursa-sb May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions packages/rulesets/src/oas/__tests__/duplicated-entry-in-enum.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,4 +105,57 @@ testRule('duplicated-entry-in-enum', [
},
],
},

{
name: 'oas3: enum as discriminator mapping key',
document: {
openapi: '3.0.2',
components: {
schemas: {
Pet: {
type: 'object',
discriminator: {
propertyName: 'petType',
mapping: {
enum: '#/components/schemas/Cat',
},
},
},
},
},
},
errors: [],
},

{
name: 'oas3: enum as example value property',
document: {
openapi: '3.0.2',
paths: {
'/test': {
get: {
responses: {
'200': {
description: 'ok',
content: {
'application/json': {
examples: {
sample: {
value: {
foo: {
enum: 'someString',
},
},
},
},
},
},
},
},
},
},
},
},
errors: [],
},
]);
2 changes: 1 addition & 1 deletion packages/rulesets/src/oas/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ const ruleset = {
severity: 'warn',
recommended: true,
message: '{{error}}',
given: ["$..[?(@property !== 'properties' && @ && @.enum)]"],
given: ["$..[?(@property !== 'properties' && @.enum && @.enum.constructor.name === 'Array')]"],

@anderaus anderaus May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the @ && null guard removed on purpose? I believe I'm seeing crashes when nimma hits a null node.

@anderaus anderaus May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be:
$..[?(@property !== 'properties' && @ && @.enum && @.enum.constructor.name === 'Array')]

then: {
field: 'enum',
function: oasSchema,
Expand Down
Loading