fix: simplify styled-auth example and fix react-styled fullscreen auth layout#33
Merged
fix: simplify styled-auth example and fix react-styled fullscreen auth layout#33
Conversation
alikhere
force-pushed
the
fix/simplify-styled-auth
branch
from
0334a78 to
ffb4f00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a few issues related to the
styled-authexample and thereact-styledauth layout.The
styled-authexample previously included extra CSS and unnecessary props (serviceName,termsUrl), which made the quick-start example more complex than needed. Since this package provides pre-styled components, the example should be minimal and reflect real usage—where users can simply install the package and use the components without adding custom styles. The example has been simplified accordingly.Additionally, the styled auth UI had layout issues (white margins and a vertical scrollbar), causing the background image not to render edge-to-edge. This has been fixed by updating global styles to ensure a proper full-viewport layout without overflow.
Finally, a missing
index.htmlfile in theexamples/iframe-authdirectory has been restored to avoid potential build and CI issues.Screenshot
Before:
After: