fix: resolve SpaceList and delegation bugs, clean up auth defaults#35
Merged
fix: resolve SpaceList and delegation bugs, clean up auth defaults#35
Conversation
…tead of discarding archive bytes
…ports from packages/react
…ke renderTerms fully opt-in
…state from settings view
…remove terms note, update header to 'Storage Dashboard' with tagline
…d web3mail integrations
alikhere
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves two known runtime bugs, removes the incomplete RewardsSection component across the entire codebase, eliminates the default Terms of Service text from the auth form, and standardises the login/header branding across all headless examples.
Bug Fixes
SpaceList — isValidating never set correctly
fetchUploadsreadisValidatingvia a stale closure sosetIsValidating(true)was dead code and the context value was alwaysfalse. Fixed by adding anisRefreshboolean parameter tofetchUploadsand passingtruefromrefresh().ChangePlan — billing delegation silently did nothing
handleSubmitcalleddelegation.archive()and discarded the CAR bytes so the delegation was never sent anywhere. Fixed by callingclient.capability.access.delegate({ space, delegations })which actually invokes the UCAN capability and propagates the delegation to the access service.Removals
RewardsSectionand all its sub-components were hardcoded to zero with TODO comments throughout and had no real data source. Partner apps embedding this toolkit have no use for Storacha-specific rewards UI in their own product — it would only add noise to their interface. Removed the component, all exports, usages in examples, integration guides, and the related test.Branding and UI Updates
The headless examples now demonstrate how a partner app can embed the toolkit with their own branding and UI rather than inheriting Storacha-specific copy. The login heading, header title, and Terms of Service defaults have all been replaced with neutral copy that a partner would actually use in their own product. The
headless-authexample has been rewritten to matchfull-app-headlessexactly, giving partners a clean reference implementation to build from.