Skip to content

fix: destructured save#272

Merged
alanshaw merged 2 commits intomainfrom
fix/destructured-save
Dec 11, 2022
Merged

fix: destructured save#272
alanshaw merged 2 commits intomainfrom
fix/destructured-save

Conversation

@alanshaw
Copy link
Member

@alanshaw alanshaw commented Dec 8, 2022

Destructuring the save method of the passed store is causing problems when the store wants to access instance vars/methods.

@alanshaw alanshaw requested a review from hugomrdias December 8, 2022 14:38
@alanshaw alanshaw merged commit a4f20a9 into main Dec 11, 2022
@alanshaw alanshaw deleted the fix/destructured-save branch December 11, 2022 13:03
alanshaw pushed a commit that referenced this pull request Dec 13, 2022
🤖 I have created a release *beep* *boop*
---


##
[9.1.0](access-v9.0.1...access-v9.1.0)
(2022-12-13)


### Features

* sync encode/decode delegations
([#276](#276))
([ab981fb](ab981fb))


### Bug Fixes

* destructured save
([#272](#272))
([a4f20a9](a4f20a9))
* handle Buffer serialization
([#277](#277))
([6dc77ca](6dc77ca))
* make d1 spaces.metadata nullable and change to kysely
([#284](#284))
([c8a9ce5](c8a9ce5)),
closes [#280](#280)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
gobengo pushed a commit that referenced this pull request Apr 11, 2023
gobengo pushed a commit that referenced this pull request Apr 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[9.1.0](access-v9.0.1...access-v9.1.0)
(2022-12-13)


### Features

* sync encode/decode delegations
([#276](#276))
([9d48372](9d48372))


### Bug Fixes

* destructured save
([#272](#272))
([b6aaf9b](b6aaf9b))
* handle Buffer serialization
([#277](#277))
([8e8f745](8e8f745))
* make d1 spaces.metadata nullable and change to kysely
([#284](#284))
([7f09479](7f09479)),
closes [#280](#280)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
tx-ravenxbsw3 added a commit to tx-ravenxbsw3/w3up that referenced this pull request Sep 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[9.1.0](storacha/w3up@access-v9.0.1...access-v9.1.0)
(2022-12-13)


### Features

* sync encode/decode delegations
([#276](storacha/w3up#276))
([ab981fb](storacha/w3up@ab981fb))


### Bug Fixes

* destructured save
([#272](storacha/w3up#272))
([a4f20a9](storacha/w3up@a4f20a9))
* handle Buffer serialization
([#277](storacha/w3up#277))
([6dc77ca](storacha/w3up@6dc77ca))
* make d1 spaces.metadata nullable and change to kysely
([#284](storacha/w3up#284))
([c8a9ce5](storacha/w3up@c8a9ce5)),
closes [#280](storacha/w3up#280)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants