fix: align postmark/welcome.txt with .html version#403
Closed
natevw wants to merge 6 commits intostoracha:mainfrom
Closed
fix: align postmark/welcome.txt with .html version#403natevw wants to merge 6 commits intostoracha:mainfrom
natevw wants to merge 6 commits intostoracha:mainfrom
Conversation
Fix: typos Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
When explicitly passing `null` a default value is not set.
this fixes storacha#356 in the repo, but will need to be applied in Postmark before truly resolved (xref storacha#402)
Contributor
Author
|
@travis could you take a look and if it looks good, get this merged here and pasted into Postmark too? |
nate-dag
pushed a commit
to natevw/w3protocol
that referenced
this pull request
Jan 27, 2023
the plaintext version of this is just dumped in roughly, due to storacha#356 while waiting for merge of storacha#403
Closed
8 tasks
Contributor
|
closing, moved to #431 |
travis
added a commit
that referenced
this pull request
Feb 9, 2023
Closed
8 tasks
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
Draft
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's an update to the plaintext version of the email validation Welcome template. I've basically just made it match the HTML version ± verbatim except the wording around the link button itself which didn't make sense in a plaintext context.
This fixes #356 in the repo, but when this is merged someone with Postmark account access will need to paste the new content there manually before the situation is truly resolved. (See https://github.com/web3-storage/w3protocol/blob/953cbae/packages/access-api/postmark/README.md and xref #402.)