lvm: Add support for reading lvm.conf #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
force-pushed
the
master_lvm-config-get
branch
from
e54b90f to
b1e670a
Compare
tbzatek
approved these changes
Jan 29, 2025
Member
tbzatek
left a comment
tbzatek
left a comment
There was a problem hiding this comment.
Just a couple of suggestions, looks good anyway.
| * | ||
| * Tech category: %BD_LVM_TECH_CONFIG no mode (it is ignored) | ||
| */ | ||
| gchar* bd_lvm_config_get (const gchar *section, const gchar *setting, const gchar *type, gboolean values_only, gboolean global_config, const BDExtraArg **extra, GError **error) { |
Member
There was a problem hiding this comment.
Hmmm wouldn't it be better to move this to someting like lvm-common.c and link it in the both plugins? Seems like a pure 1:1 copy-paste.
Member
Author
There was a problem hiding this comment.
Yes, there are more functions like this already, someone should do something about it :-)
Just a simple API using the lvmconfig command.
vojtechtrefny
force-pushed
the
master_lvm-config-get
branch
from
b1e670a to
b80948c
Compare
vojtechtrefny
merged commit de9ecdb
into
storaged-project:master
42 of 46 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple API using the lvmconfig command.