Skip to content

Support magnify beside feature #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 9, 2020
Merged

Support magnify beside feature #118

merged 4 commits into from
Jul 9, 2020

Conversation

@dijs
Copy link
Contributor

@dijs dijs commented Jun 26, 2020 •
edited
Loading

Screen Shot 2020-06-26 at 7 39 10 PM

  • Try to use block all the time

@dijs dijs requested a review from kevhender June 26, 2020 16:41
@dijs dijs added wip and removed wip labels Jun 26, 2020
@dijs
Copy link
Contributor Author

dijs commented Jun 26, 2020

This requires a bit of setup and styling on the project's part. But I think that is better since it allows them to be more flexible with this feature.

@kevhender
Copy link
Contributor

kevhender commented Jun 30, 2020

So how does this feature get used? By setting enlargedImagePosition to beside in the magnifyProps? Seems like that becomes the default here now, no? https://www.npmjs.com/package/react-image-magnify

@kevhender kevhender merged commit a8dd58b into master Jul 9, 2020
@kevhender kevhender deleted the support-magnify-beside branch July 9, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kevhender kevhender kevhender approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dijs @kevhender