Skip to content

Added lazy hydrate component #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 13, 2020
Merged

Added lazy hydrate component #55

merged 10 commits into from
May 13, 2020

Conversation

@dijs
Copy link
Contributor

@dijs dijs commented Mar 2, 2020 •
edited
Loading

  • Verify stylesheets are removed only on hydration
  • Add tests
  • Document hydrated prop
  • Try only using _hydrated in components, set by prop. Don't use both in logic

@dijs dijs requested a review from markbrocato March 2, 2020 15:13
@kevhender kevhender added the enhancement New feature or request label Mar 3, 2020
@dijs dijs requested a review from tonylepmets March 10, 2020 14:30
tonylepmets
tonylepmets reviewed Mar 10, 2020
View reviewed changes
tonylepmets
tonylepmets reviewed Mar 10, 2020
View reviewed changes
@dijs dijs requested a review from tonylepmets April 14, 2020 18:56
@kevhender kevhender merged commit bb9e82c into master May 13, 2020
@kevhender kevhender deleted the lazy-hydrate branch May 13, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markbrocato markbrocato Awaiting requested review from markbrocato

1 more reviewer

@tonylepmets tonylepmets tonylepmets approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dijs @tonylepmets @kevhender