Only prefetch in production and in dev with process.env.SERVICE_WORKE… #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevhender
reviewed
May 12, 2020
dijs
reviewed
May 13, 2020
dijs
reviewed
May 14, 2020
dijs
reviewed
May 14, 2020
dijs
suggested changes
May 14, 2020
Contributor
dijs
left a comment
dijs
left a comment
There was a problem hiding this comment.
Please handle the request object in fetch
…community/react-storefront into no-prefetch-without-sw
dijs
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…R set to true. This prevents prefetching in development when the service worker is off - which will just bog down the local node server.