Mock global.fetch in tests instead of calling the live USPS API#2
Merged
Conversation
The tracking tests hit the live USPS sandbox (apis-tem.usps.com), which intermittently returns 503 and had kept CI red for weeks. Replace fetch with a node:test mock that routes the oauth and tracking endpoints to canned responses — no live calls, no new dependencies. Runs serially (global fetch mocking and concurrency don't mix) and clears the memory-cache token singleton between tests. The invalid-URL test still uses real fetch to assert its parse error. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Coverage Report for CI Build 26414019541Coverage remained the same at 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tracking tests call the live USPS sandbox (
apis-tem.usps.com), which intermittently returns 503 and has kept CI red for weeks. This replacesfetchwith anode:testmock that routes the oauth and tracking endpoints to canned responses — no live calls, no new dependencies.Details
mockUspsFetch()router stubs/oauth2/v3/tokenand/tracking/v3r2/trackingfetchmocking andconcurrency: truedon't mix) and clears thememory-cachetoken singleton between testsfetchto assert its parse errorfetchwas called exactly once on the secondgetAccessToken()Test plan
npm test→ 10 pass / 0 fail, ~40ms (was minutes of live calls)npx eslint test/index.jsclean🤖 Generated with Claude Code