Skip to content

fix stale helper exports for build plugins#15

Merged
sullivanpj merged 1 commit into
storm-software:mainfrom
jamilahmadzai:fix-powerlines-helper-exports
Jun 24, 2026
Merged

fix stale helper exports for build plugins#15
sullivanpj merged 1 commit into
storm-software:mainfrom
jamilahmadzai:fix-powerlines-helper-exports

Conversation

@jamilahmadzai

Copy link
Copy Markdown
Contributor

Summary

This removes stale helper subpath exports from the build plugin package manifests:

  • @powerlines/plugin-tsup
  • @powerlines/plugin-vite
  • @powerlines/plugin-tsdown
  • @powerlines/plugin-esbuild
  • @powerlines/plugin-rolldown

Those package.json exports point at dist/helpers/... files that are not present in the published packages or in these package source trees, so consumers can resolve a helper subpath and then fail at runtime with ERR_MODULE_NOT_FOUND.

The root exports, ./types exports, and ./package.json exports are unchanged.

Reproduction

For example, with the current published @powerlines/plugin-tsup@0.12.596 package:

mkdir -p /tmp/powerlines-plugin-tsup-pack-repro/node_modules/@powerlines
cd /tmp/powerlines-plugin-tsup-pack-repro
npm pack --silent @powerlines/plugin-tsup@0.12.596
mkdir -p node_modules/@powerlines/plugin-tsup
tar -xzf powerlines-plugin-tsup-0.12.596.tgz -C node_modules/@powerlines/plugin-tsup --strip-components=1
node --input-type=module -e "console.log(await import.meta.resolve('@powerlines/plugin-tsup/helpers'))"
node --input-type=module -e "await import('@powerlines/plugin-tsup/helpers')"

import.meta.resolve() points to dist/helpers/index.mjs, but that file is not included in the package, so importing it fails.

Validation

  • Checked the changed package manifests no longer expose any ./helpers* export keys.
  • git diff --check
  • pnpm install --frozen-lockfile --ignore-scripts

I also attempted to run the plugin-tsup Vitest entry directly, but the test process stops during setup before executing tests because the installed @storm-software/tsup package imports @nx/js/src/utils/buildable-libs-utils without the .js extension under this Node/ESM setup. This change is limited to package export metadata.

@jamilahmadzai jamilahmadzai requested a review from a team June 20, 2026 13:10
@sullivanpj sullivanpj enabled auto-merge June 24, 2026 13:42
@sullivanpj sullivanpj disabled auto-merge June 24, 2026 13:57
@sullivanpj sullivanpj merged commit 5bca9eb into storm-software:main Jun 24, 2026
10 checks passed
@storm-software storm-software locked and limited conversation to collaborators Jun 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants