Closed
Conversation
Contributor
|
I am working on a larger overhaul of the comparator. I will include the changes you suggested here in that PR (to be uploaded soon). |
Contributor
Author
|
Sounds good. Feel free to close this PR then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ConstantComparator had two issues in my view.
Comparison with equal should take the maximum instead of the sum for relative precision. This also follows how python computes isclose.
Currently, the check 0.4 == 0.6 with relative precision 0.2 would yield true (0.2 <= 0.2*(0.4+0.6)) but should be false instead (0.2 <= 0.2* max(0.4,0.6)).
The less than comparison is also not right in my view.
Currently, the check 0.9 < 1 is false because of 0.9 < 1 - 0.2.
The proposed fix does lead to some errors though, because e.g. in the SparseMatrix a check
isLess(0.1, 0)now yields true.Should we also adapt the check in the SparseMatrix or define IsLess in a different way?