Only require MultiObjectiveSettings if needed#857
Conversation
|
I don't understand how this fixes the problem. Wouldnt the fix be that storm-pars needs to initialize multi-objective settings? |
|
Let's call it a workaround ;). The proper fix would indeed be to initialize the multi-objective setting in storm-pars as well. However, this settings module should not be relevant for storm-pars because we cannot do multi-objective queries on parametric models (as far as I know). So adding this could introduce some confusion. Maybe the best way for now would be to indeed add the setting to storm-pars. |
tquatmann
left a comment
There was a problem hiding this comment.
Since #805 both options --io:propsasmulti and --multiobjective:lex could eventually be abolished since we now have first-class support of multi-objective and lexicographic properties in PRISM- and JANI-style specifications.
For now, this PR works fine as a workaround and we don't lose anything by merging it.
|
Given the discusson above, lets merge this but maybe track this in an issue |
Co-authored-by: Tim Quatmann <tim.quatmann@cs.rwth-aachen.de>
Running
storm-parslead to an errorCannot retrieve unknown module 'multiobjective'.. This is fixed now by only requiring the setting if needed. There might be a more elegant solution though.Was introduced with #805