Add interpreter lock release to POMDP check function#158
Add interpreter lock release to POMDP check function#158AlexBork wants to merge 1 commit intostormchecker:masterfrom
Conversation
|
Can you elaborate a bit more on the change? As far as I understand, |
|
Sorry, there was a misunderstanding of the problem on my side. The problem was indeed that the model checker was keeping the interpreter lock, so other processes were not able to restart it while it was suspended. I have changed the title and description to account for that. |
|
Thanks for the clarification. |
|
Sorry, I was not aware of this issue. I am also concerned about this, in particular as it depends on the options whether or not this is actuallly code that is meant to run in parallel. I would be more comfortable with a function run_check or something. We could then have a more general policy that such functions that are meant to run in parallel are always starting with run_*? |
|
Maybe checking for signals in pybind is an option? |
|
Is there any update on this? I don't think we will merge this code here as is. Marking it for closed right now, happy to reopen though. |
The POMDP check function binding is lacking the release of the global interpreter lock that allows other processes to take control of a stopped belief exploration model checker.
Thanks to @TheGreatfpmK for pointing this out.