Cleanup unit tests. #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
...on the test failure: this seems to be related to changes to the document build that was introduced as part of 87e19c4? |
Contributor
|
This looks good, thanks! I believe I can replace some of the iteration you're doing with a search request, that will save some requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Stormpath test resources once the tests have run.
tearDown()will now remove API keys, users, and groups as well and prevent the Stormpath web interface dashboard from being polluted with old test resources.The only way I could track down the API keys were to iterate through all accounts looking for applications with names in the correct
flask-stormpath-testsformat. This seems a little inefficient, but I couldn't find the API keys in the key list of either the application or account resources directly.I also switched from the deprecated
flask.extimport format to the newflask_stormpathwhile I was at it.Fixes #83.