This repository was archived by the owner on Dec 12, 2018. It is now read-only.
1073 asymmetric keys #1210
Merged
1073 asymmetric keys #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/source/forwarded-request.rst # extensions/spring/cloud/stormpath-zuul-spring-cloud-starter/src/main/java/com/stormpath/spring/cloud/zuul/autoconfigure/StormpathZuulAutoConfiguration.java # extensions/spring/cloud/stormpath-zuul-spring-cloud-starter/src/main/java/com/stormpath/spring/cloud/zuul/config/JwkConfig.java
dogeared
reviewed
Jan 11, 2017
| bcLoaded.set(true); | ||
|
|
||
| } catch (UnknownClassException e) { | ||
| //not available |
Member
There was a problem hiding this comment.
maybe a warn or debug log message? Nature abhors an empty catch block! ;)
Member
Author
There was a problem hiding this comment.
This is a perfectly fine/expected condition, but I suppose a debug statement couldn't hurt, except for waiting for CI for another hour before merge. :/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds asymmetric private key support to #1073