Skip to content
This repository was archived by the owner on Dec 12, 2018. It is now read-only.

Conversation

@josebarrueta
Copy link
Member

@josebarrueta josebarrueta commented Jan 11, 2017

Fixes #1212

@josebarrueta josebarrueta added this to the 1.3.0 milestone Jan 11, 2017
@josebarrueta josebarrueta self-assigned this Jan 11, 2017

protected void updatedSaveableError(Saveable input, int expectedErrorCode){
Throwable e = null;
static void updatedSaveableError(Saveable input, int expectedErrorCode) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why static?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an Intellij recommendation, I think the reason was because there is no instance state require in the method.

@dogeared
Copy link
Member

@josebarrueta - only one comment about static on method in test.

@josebarrueta josebarrueta merged commit 10e3b95 into master Jan 11, 2017
@josebarrueta josebarrueta deleted the Issue-1212 branch January 11, 2017 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants