This repository was archived by the owner on Dec 12, 2018. It is now read-only.
Add id_token to OAuthGrantRequestAuthenticationResult #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhericks
changed the title
jhericks
changed the title
dogeared
changed the title
dogeared
suggested changes
Jan 16, 2017
| * Returns the String that corresponds to the OpenID Connect id_token (if present) created during the Create Grant | ||
| * Authentication operation. | ||
| * @return the String representation of the OpenID Connect id_token | ||
| */ |
| static final StringProperty EXPIRES_IN = new StringProperty("expires_in"); | ||
| static final StringProperty ACCESS_TOKEN_HREF = new StringProperty("stormpath_access_token_href"); | ||
|
|
||
| static final Map<String, Property> PROPERTY_DESCRIPTORS = createPropertyDescriptorMap(ACCESS_TOKEN, REFRESH_TOKEN, EXPIRES_IN, TOKEN_TYPE, ACCESS_TOKEN_HREF); |
Member
There was a problem hiding this comment.
don't you need to add ID_TOKEN to the PROPERTY_DESCRIPTORS Map?
Author
There was a problem hiding this comment.
Fixed, although the PROPERTY_DESCRIPTORS of this class seem to be unused in any code path. It only seems relevant in clearing CustomData and to the DefaultAccountModelFactory.
dogeared
approved these changes
Jan 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1229
Getting a token from the REST API MAY include an
id_token. This PR makes that token available in the API when present.