Add support for the registration view model#39
Merged
Conversation
| text: this.props.text || 'Loading...' | ||
| }); | ||
| }, this.props.showAfter || 250); | ||
| }, this.props.showAfter || 250); |
Contributor
There was a problem hiding this comment.
What has actually changed here, is it another type of whitespace or what? :)
Contributor
|
This works just like expected 👍 Regarding |
timothyej
pushed a commit
that referenced
this pull request
Feb 25, 2016
Add support for the registration view model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the registration view model.
Notes
The reason why I've added default fields is just so that the SDK is backwards-compatible with
stormpath-express< v3.0.0. I.e. if the GET request to/registerfails, then it simply defaults to the standard default form.Also, I first named the method
getRegisterViewDataasgetRegisterationViewData.Registrationsounds better to me, but decided to renamed it back toRegisterbecause it was more consistent with the endpoint.Any thoughts?
How to verify
$ npm run build).$ npm link).framework-spec-upgradebranch ofexpress-stormpath.$ npm link).$ npm link react-stormpath).$ npm link express-stormpath).$ npm start)./register.web.register.fields./register.web.register.fields.Fixes #32.