Add support for updating the user profile#44
Conversation
1560a2f to
bdf91e1
Compare
bdf91e1 to
85ec06f
Compare
85ec06f to
f86573a
Compare
|
Looks good! Verified with the feature-profile-support branch in the sample project, and the account-save fix branch in the Node SDK. |
|
Awesome! I'm going to go ahead and merge this in. |
Add support for updating the user profile
|
@typerandom I just forked the example app and tested the update profile functionality now that all PR's have been merged but I get the following error when submitting the form: |
|
@davekingsnorth What version of the |
|
@typerandom When I update profile it makes an xhr POST request to |
|
Have you added a handler for POST |
|
Also, by the way. If you are using the branch of this PR, then please instead checkout the master branch. This PR has been merged, so there might have been changes to the master branch related to this. |
|
The documentation that you should follow is here: https://github.com/stormpath/stormpath-sdk-react/blob/master/docs/api.md#userprofileform |
|
@davekingsnorth I'm sorry. I thought that we had cut a new release with the profile form changes in it. But we haven't. When you run the example app you need to use this branch. It should fix your issues. Let me know if that helped you :) And sorry for the confusion! |
|
@typerandom no worries, appreciate your help. This project will be awesome once I can get profile updates and custom data working. I have checked out the I still get the same issue though:
|
|
Thanks for your patience! And yes, once this is done, it will be really awesome:) I also think you'll like the new social login support (see #46). If you ever need to use that. The Regarding the In one of the early versions I used Could it be that you are using an old version? If you run Also... After you've checked this out... Did you rebuild it? I.e. At least, that's a mistake I've done a few times myself :) |
|
@typerandom Hi, just tried the following:
And still have these problems:
It feels like the npm Any suggestions? Are you able to replicate this issue? Thanks. |
Adds support for updating the user profile with the UserProfileForm component.
Before review
This depends on #43 (add router context support) to be merged. I.e. that PR needs to be merged before we can review this one.
Also, we need to merge this Node SDK PR, because without it any profile validation errors won't be shown.
Note: This PR does not support customData. There's a separate issue for adding support for that.
How to verify
$ npm run build).$ npm link).$ npm link react-stormpath).src/pages/ProfilePage.js.UserProfileFormcomponent fromreact-stormpath.<form className="form-horizontal" submit={this.onFormSubmit.bind(this)}>) with the new UserProfileForm component (i.e.<UserProfileForm />).server.jsand add the following route to it./profile(you should automatically have navigated here if you have logged in).Fixes #18.