refactor + enhanced ui #26
Conversation
…layout components
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
|
@coderabbitai review the pr |
|
The author of this PR is on the CodeRabbit Free Plan. In order to use the Chat feature, please upgrade the PR author to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. |
| const document = await this.documentsRepo.findById(documentId); | ||
|
|
||
| if (!document) { | ||
| if (!document || !document.filePath) { |
There was a problem hiding this comment.
Critical bug: The code checks !document.filePath but findById() at line 323 doesn't select the filePath field (see documents.repository.ts lines 91-100). This will always evaluate to true, causing "Document not found" errors on valid documents.
// Fix in documents.repository.ts - add filePath to select
.select({
id: documents.id,
binId: documents.binId,
filename: documents.filename,
fileType: documents.fileType,
fileSize: documents.fileSize,
filePath: documents.filePath, // ADD THIS
content: documents.content,
createdAt: documents.createdAt,
updatedAt: documents.updatedAt,
})Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
…layout components