Skip to content

Sco 2022 implement reusable audience csv export servicecontroller in#106

Merged
JannieT merged 31 commits intonavigatorsfrom
sco-2022-implement-reusable-audience-csv-export-servicecontroller-in
Apr 14, 2026
Merged

Sco 2022 implement reusable audience csv export servicecontroller in#106
JannieT merged 31 commits intonavigatorsfrom
sco-2022-implement-reusable-audience-csv-export-servicecontroller-in

Conversation

@timosville
Copy link
Copy Markdown
Contributor

While we wait for the design for the export button.

@timosville timosville requested a review from JannieT March 23, 2026 06:21
@linear
Copy link
Copy Markdown

linear Bot commented Mar 23, 2026

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Mar 23, 2026

Deploying kit with  Cloudflare Pages  Cloudflare Pages

Latest commit: 13c8919
Status: ✅  Deploy successful!
Preview URL: https://c051f5fa.kit-atq.pages.dev
Branch Preview URL: https://sco-2022-implement-reusable.kit-atq.pages.dev

View logs

@github-actions github-actions Bot requested a deployment to kit (Preview) March 23, 2026 06:24 Abandoned
Copy link
Copy Markdown
Member

@JannieT JannieT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far Timothy!

Comment thread src/backend/services/audience_service.ts Outdated
@github-actions github-actions Bot requested a deployment to kit (Preview) March 23, 2026 07:51 Abandoned
@timosville timosville requested a review from JannieT March 23, 2026 08:03
@github-actions github-actions Bot requested a deployment to kit (Preview) March 23, 2026 08:05 Abandoned
@github-actions github-actions Bot requested a deployment to kit (Preview) March 24, 2026 04:16 Abandoned
@github-actions github-actions Bot requested a deployment to kit (Preview) March 24, 2026 06:04 Abandoned
@github-actions github-actions Bot requested a deployment to kit (Preview) March 24, 2026 07:35 Abandoned
@github-actions github-actions Bot requested a deployment to kit (Preview) March 24, 2026 08:29 Abandoned
@github-actions github-actions Bot requested a deployment to kit (Preview) March 24, 2026 08:32 Abandoned
@timosville timosville marked this pull request as ready for review March 24, 2026 09:00
@github-actions github-actions Bot requested a deployment to kit (Preview) March 24, 2026 09:27 Abandoned
Copy link
Copy Markdown
Member

@JannieT JannieT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good improvements Timothy. Let's move the goal posts and make it even more scalable to handle thousands of users. I have left some suggestions for this.

Comment thread src/backend/stubs/controllers/audiences_controller.stub Outdated
Comment thread src/backend/configure.ts Outdated
Comment thread src/frontend/audiences/audiences-index.vue Outdated
@github-actions github-actions Bot requested a deployment to kit (Preview) March 25, 2026 02:55 Abandoned
@github-actions github-actions Bot requested a deployment to kit (Preview) March 25, 2026 08:11 Abandoned
@github-actions github-actions Bot requested a deployment to kit (Preview) March 25, 2026 08:17 Abandoned
@github-actions github-actions Bot requested a deployment to kit (Preview) March 25, 2026 08:22 Abandoned
@timosville timosville requested a review from JannieT March 25, 2026 08:23
@JannieT
Copy link
Copy Markdown
Member

JannieT commented Apr 13, 2026

@JannieT JannieT merged commit ebf74e2 into navigators Apr 14, 2026
3 checks passed
@JannieT JannieT deleted the sco-2022-implement-reusable-audience-csv-export-servicecontroller-in branch April 14, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants