Skip to content

fix: alternate links are optional #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

fix: alternate links are optional #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c838c6
fix: alternate links are optional
silasjoisten Sep 18, 2025
f4f30b4
Fix
silasjoisten Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/Domain/Value/Link.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,14 @@ public function __construct(array $values)
Assert::keyExists($values, 'published');
$this->isPublished = true === $values['published'];

Assert::keyExists($values, 'alternates');
Assert::isArray($values['alternates'], 'The value of the "alternates" key must be an array. Got: %s');
$this->alternates = array_map(static fn (array $values) => new LinkAlternate($values), $values['alternates']);
$alternates = [];

if (\array_key_exists('alternates', $values) && null !== $values['alternates'] && [] !== $values['alternates']) {
Assert::isArray($values['alternates'], 'The value of the "alternates" key must be an array. Got: %s');
$alternates = array_map(static fn (array $values): LinkAlternate => new LinkAlternate($values), $values['alternates']);
}

$this->alternates = $alternates;
}

public function isFolder(): bool
Expand Down
1 change: 0 additions & 1 deletion src/Resolver/StoryResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public function resolve(array $target, array $relations): array
$relationMap[$relation['uuid']] = $relation;
}


// Resolve relations within the relation map first
$this->doResolve($relationMap, $relationMap);

Expand Down
35 changes: 35 additions & 0 deletions tests/Unit/Domain/Value/LinkTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,41 @@ public function getNameWithLangAndAlternate(): void
self::assertSame($name, (new Link($values))->getName($lang));
}

#[Test]
public function alternateIsOptional(): void
{
$faker = self::faker();

$values = $faker->linkResponse();
unset($values['alternates']);

self::assertEmpty((new Link($values))->alternates);
}

#[Test]
public function alternateIsOptionalWithEmptyArray(): void
{
$faker = self::faker();

$values = $faker->linkResponse();
unset($values['alternates']);
$values['alternates'] = [];

self::assertEmpty((new Link($values))->alternates);
}

#[Test]
public function alternateIsOptionalWithNull(): void
{
$faker = self::faker();

$values = $faker->linkResponse([
'alternates' => null,
]);

self::assertEmpty((new Link($values))->alternates);
}

#[Test]
public function getNameWithNullReturnsDefaultName(): void
{
Expand Down