Avoid es-toolkit barrel import in RN UI common#880
Merged
Conversation
🦋 Changeset detectedLatest commit: 417e533 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dannyhw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates
@storybook/react-native-ui-commonso React Native code no longer imports from the top-leveles-toolkitbarrel.StoryHash.tsnow imports only the needed helpers from the package subpath entrypoints.Root Cause
Fresh consumer installs can resolve the
@storybook/react-native-ui-commones-toolkitdependency range toes-toolkit@1.46.0. That version has a top-level entrypoint that eagerly exports error classes extendingDOMException. React Native/Hermes does not provideDOMException, so evaluating the unrelated top-level barrel can crash even thoughStoryHash.tsonly needscountBy,isEqual, andmergeWith.Validation
es-toolkit@1.46.0.require("es-toolkit")throws whenDOMExceptionis absent.es-toolkit/array,es-toolkit/object, andes-toolkit/predicateload withoutDOMException.pnpm -F @storybook/react-native-ui-common check:types.es-toolkitimports/requires.