feat: honor parameters[paramKey].disable on addon panels#889
Open
Mathbl wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 7021be7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #888.
What this changes
React Native Storybook now honors
parameters[paramKey].disable, the standard Storybook convention for hiding individual addon panels per story.paramKeymatchesstory.parameters[paramKey].disable === trueis filtered out of the addons tab list.Before this PR, every panel rendered for every story regardless of parameters. This brings parity with web Storybook.
How to test
Run
examples/expo-example(iOS or Android dev client) and add a story withparameters: { controls: { disable: true } }. The Controls tab should be hidden for that story. Disable every panel for a story to verify the whole addons UI hides. Same withEXPO_PUBLIC_LITE_UI=truefor the lite UI.