feat: add the register_ip_and_attach_pil_terms_and_distribute_royalty_tokens method #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd distributing royalty tokens in IPAsset class
…etadata in IPAsset class
bonnie57
requested review from
AndyBoWu,
edisonz0718,
limengformal,
lucas2brh and
sebsadface
as code owners
bonnie57
changed the title
…te_royalty_tokens method to use RoyaltyShareInput for improved type safety
bonnie57
changed the title
lucas2brh
approved these changes
Oct 21, 2025
bonnie57
added a commit
that referenced
this pull request
Oct 21, 2025
…ute_royalty_tokens method (#150) * feat: implement NativeRoyaltyPolicy enum and utility function for royalty policy address resolution * refactor: update royalty share handling by replacing deprecated RoyaltyShare with get_royalty_shares utility function * refactor: streamline license terms validation in IPAsset class by introducing _validate_license_terms_data method * feat: implement mint_and_register_ip_and_attach_pil_terms_and_distribute_royalty_tokens method in IPAsset class * feat: enhance IPAsset class with new test cases for minting, registering IP, and attaching PIL terms with royalty distribution * feat: add licensing configuration to IPAsset tests and enhance type annotations for clarity * refactor: move test_mint_and_register_ip_and_attach_pil_terms_and_distribute_royalty_tokens to TestIPAssetMint class for better organization * docs: improve documentation clarity in IPAsset and royalty utility functions by adding missing punctuation * feat: add the register_ip_and_attach_pil_terms_and_distribute_royalty_tokens method (#152) * test: add integration test for registering IP, attaching PIL terms, and distributing royalty tokens in IPAsset class * feat: add IPMetadataInput and related tests for registering IP with metadata in IPAsset class * fix: update type annotation for royalty_shares parameter in _distribute_royalty_tokens method to use RoyaltyShareInput for improved type safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
register_ip_and_attach_pil_terms_and_distribute_royalty_tokensmethodTest Plan
Unit tests
Integration tests